Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use toggle from embedded-hal 1.0 in the uno blink example. #497

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Use toggle from embedded-hal 1.0 in the uno blink example. #497

merged 1 commit into from
Jan 30, 2024

Conversation

ghismary
Copy link
Contributor

As embedded-hal 1.0 has now been released, make the changes that were suggested in a comment in the uno blink example.

Rahix
Rahix reviewed Jan 20, 2024
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution! Please check the CI error, I think you missed changing the import...

@ghismary ghismary force-pushed the feature/use-toggle-from-embedded-hal-1.0-in-uno-blink-example branch from 2428625 to 03f78b2 Compare January 30, 2024 14:24
@ghismary
Copy link
Contributor Author

Hi, you're right, I fixed that.

@ghismary ghismary force-pushed the feature/use-toggle-from-embedded-hal-1.0-in-uno-blink-example branch from 03f78b2 to d08589e Compare January 30, 2024 16:58
@Rahix Rahix merged commit eb818ae into Rahix:main Jan 30, 2024
23 checks passed
@Rahix
Copy link
Owner

Rahix commented Jan 30, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahix Rahix Rahix left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghismary @Rahix